نظافة CI

# CI Hygiene

## When this skill activates

Use this skill whenever the work touches the build pipeline, test runners, dependency installation, deploy workflows, or any change that can pass locally but break CI for the team.

Also use it when the work adds generated files, migration scripts, codegen, external service fixtures, package manager changes, GitHub Actions/GitLab CI/YAML workflows, Dockerfiles, or release automation.

## Baseline rules

1. CI runs the same checks a reviewer expects locally — linting, typechecking, tests, and build. None of them are optional.
2. Skipping a failing test to land a change is a regression, not a merge strategy.
3. Flaky tests are fixed or quarantined explicitly. Silent retries are not a fix.
4. Migrations run in CI against a disposable database before they run against production.
5. CI jobs use least privilege. Pull request checks, release jobs, and production deploy jobs must not share broad secrets.
6. Dependencies, images, actions, and tool versions are pinned enough to make the build reproducible and reviewable.

## If the repository has no CI

Add a minimal pipeline that runs on every pull request:

1. Install dependencies deterministically using the project's lockfile.
2. Run the linter, the typechecker, and the test suite in sequence.
3. Build the production artifact.
4. Run generated-file drift checks when the repo has generated outputs.
5. Fail the job on any non-zero exit.

Do not skip a step because "the repo doesn't have one yet" — add it in the same change.

## If the repository has CI

- Confirm the agent's change does not disable a check to make the build green.
- Confirm new behavior has a corresponding test running under the existing matrix.
- Confirm the build is reproducible — no `latest` tags, no unpinned actions, no mystery caches.
- Confirm generated files are produced by the generator and checked for drift rather than hand-edited.
- Confirm CI secrets are environment-scoped and unavailable to untrusted pull requests.

## Migration hygiene

- Schema migrations and data migrations are separate. Do not hide a data rewrite inside a schema migration.
- Every migration has a tested rollback plan, even if the plan is "restore from backup" with a documented threshold.
- Long-running migrations run out-of-band, not during the deploy window.

## Dependency hygiene

- Lockfiles are committed and enforced. CI installs from the lockfile, not the manifest.
- Security-sensitive dependency bumps land in their own change, not bundled with a feature.
- Do not add a dependency without naming the single responsibility it takes on in the code.
- For GitHub Actions or reusable workflows, pin third-party actions to a reviewed version or SHA according to the repo policy.
- Cache keys include lockfile content. Caches accelerate builds; they must not decide which dependencies are installed.

## Generated artifact hygiene

- Generated files have a single command that reproduces them.
- CI runs a drift check after generation and fails if tracked generated files changed.
- Agent instructions must say which files are canonical and which files are generated.

## Related skills

- Use `secrets-baseline` when CI variables, deploy tokens, package registry tokens, or cloud credentials are involved.
- Use `testability-check` when CI cannot run meaningful tests without invasive bootstrapping.

## References

- Run `scripts/ci-smoke.mjs` locally before pushing a change that modifies the pipeline or the build configuration.